Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in xtermTerminal.ts #175648

Merged
merged 1 commit into from Feb 28, 2023
Merged

Fix warnings in xtermTerminal.ts #175648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
View file
Open in desktop
Expand Up @@ -771,7 +771,11 @@ export class XtermTerminal extends DisposableStore implements IXtermTerminal, II
this.raw.write(data);
}
}
const enum ACCESSIBLE_BUFFER { Scheme = 'terminal-accessible-buffer' }

const enum AccessibleBufferConstants {
Scheme = 'terminal-accessible-buffer'
}

class AccessibleBuffer extends DisposableStore {
private _accessibleBuffer: HTMLElement;
private _bufferEditor: CodeEditorWidget;
Expand Down Expand Up @@ -832,7 +836,7 @@ class AccessibleBuffer extends DisposableStore {
private async _updateBufferEditor(): Promise<void> {
const commandDetection = this._capabilities.get(TerminalCapability.CommandDetection);
const fragment = !!commandDetection ? this._getShellIntegrationContent() : this._getAllContent();
const model = await this._getTextModel(URI.from({ scheme: ACCESSIBLE_BUFFER.Scheme, fragment }));
const model = await this._getTextModel(URI.from({ scheme: AccessibleBufferConstants.Scheme, fragment }));
if (model) {
this._bufferEditor.setModel(model);
}
Expand Down Expand Up @@ -868,7 +872,7 @@ class AccessibleBuffer extends DisposableStore {
this._bufferEditor.focus();
}

async _getTextModel(resource: URI): Promise<ITextModel | null> {
private async _getTextModel(resource: URI): Promise<ITextModel | null> {
const existing = this._modelService.getModel(resource);
if (existing && !existing.isDisposed()) {
return existing;
Expand Down