Introduce terminal contributions and make links one #175921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the concept of terminal contributions (that's right,
contrib/terminalContrib/!) which are modeled after editor contributions with the main goal being to simplify and reduce the size ofTerminalServiceandTerminalInstance. This is a natural extensions of the work done in #175785 and #175790, just contributions make managing the lifecycle of objects attached to instances easier.One neat feature of the new terminal contributions is that imported from
contrib/terminalContribis disallowed in the main terminal code, to prevent accidental changes that go against the new architecture.Before:
TerminalInstanceowns aTerminalLinkManagerTerminalServiceowns link providersTerminalServiceregisters link providers onTerminalInstancesMainThreadTerminalServiceregisters a link provider toTerminalServiceAfter:
TerminalInstancedoesn't know about linksTerminalLinkContributionownsTerminalLinkManagerTerminalLinkProviderServiceowns link providersTerminalLinkContributionpulls link providers fromTerminalLinkProviderServiceand registers them onTerminalLinkManagerMainThreadTerminalServiceregisters a link provider toTerminalLinkProviderService