Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notebook controller kind API proposal #175962

Merged
merged 1 commit into from Mar 15, 2023
Merged

Remove notebook controller kind API proposal #175962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion extensions/vscode-api-tests/package.json
View file
Open in desktop
Expand Up @@ -18,7 +18,6 @@
"findTextInFiles",
"fsChunks",
"notebookCellExecutionState",
"notebookControllerKind",
"notebookDeprecated",
"notebookLiveShare",
"notebookMessaging",
Expand Down
6 changes: 0 additions & 6 deletions src/vs/workbench/api/browser/mainThreadNotebookKernels.ts
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@ abstract class MainThreadKernel implements INotebookKernel {
label: string;
description?: string;
detail?: string;
kind?: string;
supportedLanguages: string[];
implementsExecutionOrder: boolean;
localResourceRoot: URI;
Expand All @@ -56,7 +55,6 @@ abstract class MainThreadKernel implements INotebookKernel {
this.label = data.label;
this.description = data.description;
this.detail = data.detail;
this.kind = data.kind;
this.supportedLanguages = isNonEmptyArray(data.supportedLanguages) ? data.supportedLanguages : _languageService.getRegisteredLanguageIds();
this.implementsExecutionOrder = data.supportsExecutionOrder ?? false;
this.localResourceRoot = URI.revive(data.extensionLocation);
Expand All @@ -79,10 +77,6 @@ abstract class MainThreadKernel implements INotebookKernel {
this.detail = data.detail;
event.detail = true;
}
if (data.kind !== undefined) {
this.kind = data.kind;
event.kind = true;
}
if (data.supportedLanguages !== undefined) {
this.supportedLanguages = isNonEmptyArray(data.supportedLanguages) ? data.supportedLanguages : this._languageService.getRegisteredLanguageIds();
event.supportedLanguages = true;
Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/api/common/extHost.protocol.ts
View file
Open in desktop
Expand Up @@ -1006,7 +1006,6 @@ export interface INotebookKernelDto2 {
label: string;
detail?: string;
description?: string;
kind?: string;
supportedLanguages?: string[];
supportsInterrupt?: boolean;
supportsExecutionOrder?: boolean;
Expand Down
9 changes: 0 additions & 9 deletions src/vs/workbench/api/common/extHostNotebookKernels.ts
View file
Open in desktop
Expand Up @@ -178,15 +178,6 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
data.description = value;
_update();
},
get kind() {
checkProposedApiEnabled(extension, 'notebookControllerKind');
return data.kind ?? '';
},
set kind(value) {
checkProposedApiEnabled(extension, 'notebookControllerKind');
data.kind = value;
_update();
},
get supportedLanguages() {
return data.supportedLanguages;
},
Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/contrib/notebook/browser/controller/apiActions.ts
View file
Open in desktop
Expand Up @@ -69,7 +69,6 @@ CommandsRegistry.registerCommand('_resolveNotebookKernels', async (accessor, arg
return kernels.all.map(provider => ({
id: provider.id,
label: provider.label,
kind: provider.kind,
description: provider.description,
detail: provider.detail,
isPreferred: false, // todo@jrieken,@rebornix
Expand Down
2 changes: 0 additions & 2 deletions src/vs/workbench/contrib/notebook/common/notebookKernelService.ts
View file
Open in desktop
Expand Up @@ -30,7 +30,6 @@ export interface INotebookKernelChangeEvent {
label?: true;
description?: true;
detail?: true;
kind?: true;
supportedLanguages?: true;
hasExecutionOrder?: true;
hasInterruptHandler?: true;
Expand All @@ -49,7 +48,6 @@ export interface INotebookKernel {
label: string;
description?: string;
detail?: string;
kind?: string;
supportedLanguages: string[];
implementsInterrupt?: boolean;
implementsExecutionOrder?: boolean;
Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/contrib/notebook/test/browser/notebookExecutionService.test.ts
View file
Open in desktop
Expand Up @@ -181,7 +181,6 @@ class TestNotebookKernel implements INotebookKernel {
constructor(opts?: { languages: string[] }) {
this.supportedLanguages = opts?.languages ?? [PLAINTEXT_LANGUAGE_ID];
}
kind?: string | undefined;
implementsInterrupt?: boolean | undefined;
implementsExecutionOrder?: boolean | undefined;
}
1 change: 0 additions & 1 deletion src/vs/workbench/services/extensions/common/extensionsApiProposals.ts
View file
Open in desktop
Expand Up @@ -45,7 +45,6 @@ export const allApiProposals = Object.freeze({
ipc: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.ipc.d.ts',
notebookCellExecutionState: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookCellExecutionState.d.ts',
notebookControllerAffinityHidden: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookControllerAffinityHidden.d.ts',
notebookControllerKind: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookControllerKind.d.ts',
notebookDeprecated: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookDeprecated.d.ts',
notebookKernelSource: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookKernelSource.d.ts',
notebookLiveShare: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookLiveShare.d.ts',
Expand Down
16 changes: 0 additions & 16 deletions src/vscode-dts/vscode.proposed.notebookControllerKind.d.ts
View file
Open in desktop

This file was deleted.