Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an overload to TextEditor.edit for insertion of a SnippetString #17628

Merged
merged 13 commits into from
Jan 20, 2017
Merged

Adding an overload to TextEditor.edit for insertion of a SnippetString #17628

merged 13 commits into from
Jan 20, 2017

Commits on Dec 16, 2016

  1. Adding insertSnippet to TextEditor extension API.

    @joelday
    joelday committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    38a3a1a View commit details
    Browse the repository at this point in the history

  2. Fix hygiene error.

    @joelday
    joelday committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    75840d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2016

  1. TextEditor.insertSnippet extension API. 

    More robust type validation on ext side of insertSnippet.
Position/range check for snippet insertion was inverted.
Adding insertSnippet to vscode.d.ts. (Should it be in vscode.proposed.d.ts?)
Adding extension API tests for insertSnippet.
    @icfjoeld
    icfjoeld committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    40522e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/Microsoft/vscode

    @icfjoeld
    icfjoeld committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    9c42a68 View commit details
    Browse the repository at this point in the history

  3. Temporarily referencing vscode.proposed.d.ts for API tests.

    @icfjoeld
    icfjoeld committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    a41b017 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2017

  1. Merge master.

    @icfjoeld
    icfjoeld committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    8a30392 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into insert-snippet-api

    @icfjoeld
    icfjoeld committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    f7587b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2017

  1. Insert snippet API changes.

    @icfjoeld
    icfjoeld committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    3c817c7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into insert-snippet-api

    @joelday
    joelday committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    c27b386 View commit details
    Browse the repository at this point in the history

  3. Fix test selection range.

    @joelday
    joelday committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    713aaff View commit details
    Browse the repository at this point in the history

  4. TextEditor.edit snippet overload now returns void. No longer preventi… 

    …ng when already in snippet mode.
    @joelday
    joelday committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    95fc032 View commit details
    Browse the repository at this point in the history

  5. Snippet insertion extension API changes 

    - Basing snippet insertion failure on a new `_codeEditor` null-check.
- Now returns `Thenable<boolean>`.
- Removed vscode.proposed.d.ts copy of the `TextEditor` change.
- Removing empty options interface.
    @icfjoeld
    icfjoeld committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    c21734f View commit details
    Browse the repository at this point in the history

  6. Reverting launch.json change.

    @icfjoeld
    icfjoeld committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    ff2ea5d View commit details
    Browse the repository at this point in the history