Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline codicons font for simple browser #176462

Merged
merged 1 commit into from Mar 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 7 additions & 12 deletions extensions/simple-browser/esbuild-preview.js
Expand Up @@ -4,7 +4,6 @@
*--------------------------------------------------------------------------------------------*/
// @ts-check
const path = require('path');
const fs = require('fs');
const esbuild = require('esbuild');

const args = process.argv.slice(2);
Expand All @@ -21,18 +20,14 @@ const srcDir = path.join(__dirname, 'preview-src');
const outDir = path.join(outputRoot, 'media');

async function build() {
fs.copyFileSync(
path.join(__dirname, 'node_modules', 'vscode-codicons', 'dist', 'codicon.css'),
path.join(outDir, 'codicon.css'));

fs.copyFileSync(
path.join(__dirname, 'node_modules', 'vscode-codicons', 'dist', 'codicon.ttf'),
path.join(outDir, 'codicon.ttf'));

await esbuild.build({
entryPoints: [
path.join(srcDir, 'index.ts')
],
entryPoints: {
'index': path.join(srcDir, 'index.ts'),
'codicon': path.join(__dirname, 'node_modules', 'vscode-codicons', 'dist', 'codicon.css'),
},
loader: {
'.ttf': 'dataurl',
},
bundle: true,
minify: true,
sourcemap: false,
Expand Down
2 changes: 1 addition & 1 deletion extensions/simple-browser/src/simpleBrowserView.ts
Expand Up @@ -125,7 +125,7 @@ export class SimpleBrowserView extends Disposable {

<meta http-equiv="Content-Security-Policy" content="
default-src 'none';
font-src ${this._webviewPanel.webview.cspSource};
font-src data:;
style-src ${this._webviewPanel.webview.cspSource};
script-src 'nonce-${nonce}';
frame-src *;
Expand Down