Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dragging custom mime types from tree view into an editor #176575

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Fix dragging custom mime types from tree view into an editor #176575

merged 2 commits into from
Apr 18, 2023

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Mar 9, 2023 •
edited

Fixes #175589

Updates the editor drag and drop handler to support data from custom tree views

@mjbvz mjbvz added this to the March 2023 milestone Mar 9, 2023
@mjbvz mjbvz requested a review from alexr00 March 9, 2023 00:07
@mjbvz mjbvz self-assigned this Mar 9, 2023
@mjbvz mjbvz enabled auto-merge (squash) March 15, 2023 21:03
@mjbvz mjbvz requested a review from alexr00 March 15, 2023 21:03
alexr00
alexr00 requested changes Mar 17, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored so we can maintain only one place for storing data for drag and drop.

src/vs/workbench/browser/parts/views/treeView.ts Outdated Show resolved Hide resolved
@mjbvz mjbvz modified the milestones: March 2023, April 2023 Mar 20, 2023
@mjbvz
Fix dragging custom mime types from tree view into an editor
2e840d7 
Fixes microsoft#175589

Introduces a new `AsyncDataTransferStore` class to facilitate setting data transfer values on a drag/copy event async
alexr00
alexr00 previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a compile error, but otherwise looks great! Thank you for redoing it to reusing the existing mechanism!

@mjbvz mjbvz merged commit 61860e8 into microsoft:main Apr 18, 2023
6 checks passed
@ScriptPup ScriptPup mentioned this pull request Apr 22, 2023
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@karrtikr karrtikr karrtikr approved these changes

@alexr00 alexr00 alexr00 left review comments

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

Cannot drag custom mime from tree view into editor
4 participants
@mjbvz @rebornix @karrtikr @alexr00