Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReviewZoneWidget makes duplicate calls to show() + hide() #176641

Merged
merged 1 commit into from
Mar 9, 2023
Merged

ReviewZoneWidget makes duplicate calls to show() + hide() #176641

merged 1 commit into from
Mar 9, 2023

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Mar 9, 2023

Fixes #174263

@alexr00 alexr00 self-assigned this Mar 9, 2023
@alexr00 alexr00 enabled auto-merge (squash) March 9, 2023 14:38
@VSCodeTriageBot VSCodeTriageBot added this to the March 2023 milestone Mar 9, 2023
@alexr00 alexr00 merged commit 61c8c7c into main Mar 9, 2023
@alexr00 alexr00 deleted the alexr00/issue174263 branch March 9, 2023 15:11
hermannloose added a commit to hermannloose/vscode that referenced this pull request Mar 13, 2023
@hermannloose
Remove redundant show() / hide() in expand() / collapse()
3312e33 
PR microsoft#176641 cleaned up the redundant, explicit calls to these methods in
`toggleExpand()` as they already happen in the
`onDidChangeCollapsibleState` listener if `_expanded` doesn't match the
new collapsible state. `hide()` was also adjusted there to call
`deleteCommentThread()` as needed.
alexr00 pushed a commit that referenced this pull request Mar 13, 2023
@hermannloose
Consistently expand or collapse all comments on a line (#176967)
d492168 
* Remove redundant `show()` / `hide()` in `expand()` / `collapse()`

PR #176641 cleaned up the redundant, explicit calls to these methods in
`toggleExpand()` as they already happen in the
`onDidChangeCollapsibleState` listener if `_expanded` doesn't match the
new collapsible state. `hide()` was also adjusted there to call
`deleteCommentThread()` as needed.

* Consistently expand or collapse all comments on a line

Fixes #77155.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrmarti chrmarti chrmarti approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

ReviewZoneWidget makes duplicate calls to show() + hide()
3 participants
@alexr00 @chrmarti @VSCodeTriageBot