Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper function for concise terminal actions #178172

Merged
merged 17 commits into from Mar 24, 2023
Merged

Add wrapper function for concise terminal actions #178172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8311f75
Add wrapper function for concise terminal actions
Tyriar Mar 23, 2023
6686614
Merge branch 'main' into tyriar/actions_concise
Tyriar Mar 24, 2023
032d76f
Convert remaining simple actions in terminalActions
Tyriar Mar 24, 2023
c562285
Add registerActiveInstanceAction
Tyriar Mar 24, 2023
e6de0c7
Return disposable
Tyriar Mar 24, 2023
cf72e21
Improve some arg casting
Tyriar Mar 24, 2023
c460749
Hide send sequence from command palette
Tyriar Mar 24, 2023
75d09d0
Improve arg safety
Tyriar Mar 24, 2023
e3cc111
Remove braces from single line run functions
Tyriar Mar 24, 2023
3689f68
Allow returning Promise<unknown>
Tyriar Mar 24, 2023
dd0b535
Improve arg handling more
Tyriar Mar 24, 2023
5d64e26
Use terminal service collection in 2 helpers
Tyriar Mar 24, 2023
69c42e8
Move some strings to terminalStrings
Tyriar Mar 24, 2023
0a22950
Improve async handling of SplitInstance, make faster
Tyriar Mar 24, 2023
3abc175
Use ITerminalServicesCollection in remaining places
Tyriar Mar 24, 2023
8b5cb0b
Remove todo
Tyriar Mar 24, 2023
e723413
Remove ITerminalInstance.doWithActiveInstance<T>
Tyriar Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/vs/workbench/contrib/terminal/browser/terminal.ts
View file
Open in desktop
Expand Up @@ -188,13 +188,6 @@ export interface ITerminalService extends ITerminalInstanceHost {
moveToTerminalView(source?: ITerminalInstance | URI): Promise<void>;
getPrimaryBackend(): ITerminalBackend | undefined;

/**
* Perform an action with the active terminal instance, if the terminal does
* not exist the callback will not be called.
* @param callback The callback that fires with the active terminal
*/
doWithActiveInstance<T>(callback: (terminal: ITerminalInstance) => T): T | void;

/**
* Fire the onActiveTabChanged event, this will trigger the terminal dropdown to be updated,
* among other things.
Expand Down