Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialogs: hint dialog content in tests to aid in debugging #178736

Merged
merged 2 commits into from Mar 31, 2023
Merged

dialogs: hint dialog content in tests to aid in debugging #178736

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60876a0
dialogs: hint dialog content in tests to aid in debugging
connor4312 Mar 30, 2023
61a0d09
Merge branch 'main' into connor4312/dialog-contents-hint-in-tests
aeschli Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/services/dialogs/common/dialogService.ts
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@ export class DialogService extends Disposable implements IDialogService {
prompt<T>(prompt: IPrompt<T>): Promise<IPromptResult<T>>;
async prompt<T>(prompt: IPrompt<T> | IPromptWithCustomCancel<T> | IPromptWithDefaultCancel<T>): Promise<IPromptResult<T> | IPromptResultWithCancel<T>> {
if (this.skipDialogs()) {
throw new Error('DialogService: refused to show dialog in tests.');
throw new Error(`DialogService: refused to show dialog in tests. Contents: ${prompt.message}`);
}

const handle = this.model.show({ promptArgs: { prompt } });
Expand Down