Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow audio to play even when not initiated with a user's gesture #179204

Merged
merged 10 commits into from Apr 5, 2023
Merged

allow audio to play even when not initiated with a user's gesture #179204

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
68f61c1
fix #176284
meganrogge Apr 4, 2023
fbeb172
Revert "fix #176284"
meganrogge Apr 5, 2023
bf142b2
add to app directly
meganrogge Apr 5, 2023
a7ccc4e
Update src/main.js
meganrogge Apr 5, 2023
7c8858b
Update src/main.js
meganrogge Apr 5, 2023
f69ec0d
Merge branch 'main' into merogge/auto-play-bypass
meganrogge Apr 5, 2023
7e7e039
add comment, move to better place
meganrogge Apr 5, 2023
86f41f8
Update src/main.js
meganrogge Apr 5, 2023
e1343af
Update src/main.js
meganrogge Apr 5, 2023
1759ad3
use unifiedAutoPlay
meganrogge Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main.js
View file
Open in desktop
Expand Up @@ -252,6 +252,11 @@ function configureCommandlineSwitchesSync(cliArgs) {
*/
app.commandLine.appendSwitch('disable-features', 'CalculateNativeWinOcclusion');

/**
* Allow media to play even if no user gesture is used to fix issues like #176284
*/
app.commandLine.appendSwitch('disable-features', 'CalculateNativeWinOcclusion,UnifiedAutoplay');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I must have misread the diff, can you de-duplicate L253 and this one. We only need single app.commandLine.appendSwitch('disable-features'


// Support JS Flags
const jsFlags = getJSFlags(cliArgs);
if (jsFlags) {
Expand Down