fixed #173858 minimap slider not scrolling to the top end #180728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #173858 I reported a few weeks ago.
When scrolling all the way to the top a div/0 happens in the else block when
options.paddingTop == scrollTop == 0
:My pull request changes the if condition to
>=
instead of>
, avoiding the div/0 by executing the else block.(Reasoning: Why should the calculation suddenly completely change when
scrollTop
, i.e. the position from the top end, changes from 1 to 0? It probably shouldn't.)Tested it by modifying my local installation, where it completely eliminated the issue.