Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nb.codeactiononsave setting, add nb.experimental to command ID #180870

Merged
merged 1 commit into from Apr 25, 2023
Merged

remove nb.codeactiononsave setting, add nb.experimental to command ID #180870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/notebook/browser/contrib/saveParticipants/saveParticipants.ts
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@ class CodeActionOnSaveParticipant implements IStoredFileWorkingCopySaveParticipa
return undefined;
}

const setting = this.configurationService.getValue<{ [kind: string]: boolean } | string[]>('notebook.codeActionsOnSave');
const setting = this.configurationService.getValue<{ [kind: string]: boolean } | string[]>('notebook.experimental.codeActionsOnSave');
if (!setting) {
return undefined;
}
Expand Down
18 changes: 9 additions & 9 deletions src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
View file
Open in desktop
Expand Up @@ -920,15 +920,15 @@ configurationRegistry.registerConfiguration({
tags: ['notebookLayout'],
default: false
},
[NotebookSetting.codeActionsOnSave]: {
markdownDescription: nls.localize('notebook.codeActionsOnSave', "Experimental. Run a series of CodeActions for a notebook on save. CodeActions must be specified, the file must not be saved after delay, and the editor must not be shutting down. Example: `notebook.format: true`"),
type: 'object',
additionalProperties: {
type: 'boolean'
},
tags: ['notebookLayout'],
default: {}
},
// [NotebookSetting.codeActionsOnSave]: {
// markdownDescription: nls.localize('notebook.codeActionsOnSave', "Experimental. Run a series of CodeActions for a notebook on save. CodeActions must be specified, the file must not be saved after delay, and the editor must not be shutting down. Example: `notebook.format: true`"),
// type: 'object',
// additionalProperties: {
// type: 'boolean'
// },
// tags: ['notebookLayout'],
// default: {}
// },
[NotebookSetting.confirmDeleteRunningCell]: {
markdownDescription: nls.localize('notebook.confirmDeleteRunningCell', "Control whether a confirmation prompt is required to delete a running cell."),
type: 'boolean',
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/notebook/common/notebookCommon.ts
View file
Open in desktop
Expand Up @@ -937,7 +937,7 @@ export const NotebookSetting = {
outputScrolling: 'notebook.output.scrolling',
textOutputLineLimit: 'notebook.output.textLineLimit',
formatOnSave: 'notebook.formatOnSave.enabled',
codeActionsOnSave: 'notebook.codeActionsOnSave',
codeActionsOnSave: 'notebook.experimental.codeActionsOnSave',
outputWordWrap: 'notebook.output.wordWrap',
outputLineHeightDeprecated: 'notebook.outputLineHeight',
outputLineHeight: 'notebook.output.lineHeight',
Expand Down