Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting started theme picker images and names to reflect new themes #180976

Merged
merged 2 commits into from Apr 26, 2023
Merged

Update getting started theme picker images and names to reflect new themes #180976

merged 2 commits into from Apr 26, 2023

Conversation

daviddossett
Copy link
Contributor

No description provided.

@daviddossett daviddossett self-assigned this Apr 26, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Apr 26, 2023
@bhavyaus
Copy link
Contributor

bhavyaus commented Apr 26, 2023 •
edited

These strings should also be updated to the new theme names so that upon clicking the image in the walkthrough step, the new themes are applied

vscode/src/vs/workbench/contrib/welcomeGettingStarted/common/media/theme_picker.ts

Line 13 in 407cb5a

<checkbox when-checked="setTheme:${ThemeSettingDefaults.COLOR_THEME_DARK}" checked-on="config.workbench.colorTheme == '${ThemeSettingDefaults.COLOR_THEME_DARK}'">

vscode/src/vs/workbench/contrib/welcomeGettingStarted/common/media/theme_picker.ts

Line 17 in 407cb5a

<checkbox when-checked="setTheme:${ThemeSettingDefaults.COLOR_THEME_LIGHT}" checked-on="config.workbench.colorTheme == '${ThemeSettingDefaults.COLOR_THEME_LIGHT}'">

@daviddossett daviddossett merged commit 5c44e81 into main Apr 26, 2023
7 checks passed
@daviddossett daviddossett deleted the ddossett/steady-pheasant branch April 26, 2023 21:20
@daviddossett daviddossett changed the title Update getting started theme picker images to reflect new themes Update getting started theme picker images and names to reflect new themes Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bhavyaus bhavyaus bhavyaus approved these changes

Assignees

@daviddossett daviddossett

Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daviddossett @bhavyaus @VSCodeTriageBot