Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #169151 fallback to editor hover if no breakpoint #181274

Merged

Conversation

Viijay-Kr
Copy link
Contributor

Closes #169151.

This PR fixes the issue mentioned in this comment
#169151 (comment)

Now when no focused stack frame is available , editor hover is shown

@roblourens roblourens added this to the May 2023 milestone May 1, 2023
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@roblourens roblourens enabled auto-merge (squash) May 1, 2023 23:33
@roblourens roblourens merged commit ed4853d into microsoft:main May 1, 2023
7 checks passed
@Viijay-Kr Viijay-Kr deleted the feat-debug-hover-improvement-2 branch May 2, 2023 07:06
russelldavis pushed a commit to russelldavis/vscode that referenced this pull request May 9, 2023
…osoft#181274)

Co-authored-by: vijay.krishna <vijay.krishna@quantilope.com>
russelldavis pushed a commit to russelldavis/vscode that referenced this pull request May 17, 2023
…osoft#181274)

Co-authored-by: vijay.krishna <vijay.krishna@quantilope.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Debug: Show Hover" does nothing when triggered from shortcut (but works with mouse)
3 participants