use editMode:preview by default for screen reader users
#182324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
approved these changes
May 15, 2023
| @@ -134,6 +136,17 @@ export class InteractiveEditorController implements IEditorContribution { | |||
| return INTERACTIVE_EDITOR_ID; | |||
| } | |||
|
|
|||
| private _getMode(): EditMode { | |||
| let editMode: EditMode = this._configurationService.getValue('interactiveEditor.editMode'); | |||
| const isDefault = editMode === EditMode.LivePreview; | |||
There was a problem hiding this comment.
Better use IConfigurationService.inspect and look at IConfigurationValue#defaultValue and value. That avoid hardcoding the (current) default and it will account for the fact where users explicitly configure live preview to be their choice.
There was a problem hiding this comment.
Sample:
vscode/src/vs/workbench/browser/parts/titlebar/windowTitle.ts
Lines 263 to 267 in efb49cc
There was a problem hiding this comment.
I will create a follow up PR
meganrogge
added a commit
that referenced
this pull request
May 15, 2023
use `editMode:preview` by default for screen reader users
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.