Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal image support #182442

Merged
merged 5 commits into from May 15, 2023
Merged

Terminal image support #182442

merged 5 commits into from May 15, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 14, 2023

This integrates https://github.com/jerch/xterm-addon-image which adds support for both sixel and iTerm's inline image protocol (png, jpeg, gif [initial frame]). It is currently disabled by default via an experimental setting which will not load the addon at all, we can remove this soon, probably when the addon is merged into the core xterm.js repo such that it's more resilient against breaking changes.

Fixes #182443

Sixel

Screenshot 2023-05-14 at 9 21 04 am

iTerm's inline image protocol

png

Screenshot 2023-05-14 at 9 22 13 am

jpeg

Screenshot 2023-05-14 at 9 24 56 am

gif

Screenshot 2023-05-14 at 9 20 05 am

@Tyriar Tyriar added this to the May 2023 milestone May 14, 2023
@Tyriar Tyriar self-assigned this May 14, 2023
@Tyriar Tyriar requested a review from meganrogge May 14, 2023 16:25
@Tyriar Tyriar marked this pull request as ready for review May 14, 2023 16:25
@Tyriar Tyriar merged commit c0377b2 into main May 15, 2023
6 checks passed
@Tyriar Tyriar deleted the tyriar/term-image branch May 15, 2023 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal image support
2 participants