Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds #181652 html audio tag for audio file #183328

Merged
merged 1 commit into from May 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -14,6 +14,7 @@ import { getDocumentDir } from '../../util/document';
enum MediaKind {
Image,
Video,
Audio,
}

export const mediaFileExtensions = new Map<string, MediaKind>([
Expand All @@ -35,6 +36,11 @@ export const mediaFileExtensions = new Map<string, MediaKind>([
// Videos
['ogg', MediaKind.Video],
['mp4', MediaKind.Video],

// Audio Files
['mp3', MediaKind.Audio],
['aac', MediaKind.Audio],
['wav', MediaKind.Audio],
]);

export const mediaMimes = new Set([
Expand All @@ -45,6 +51,9 @@ export const mediaMimes = new Set([
'image/webp',
'video/mp4',
'video/ogg',
'audio/mpeg',
'audio/aac',
'audio/x-wav',
]);


Expand Down Expand Up @@ -104,12 +113,18 @@ export function createUriListSnippet(
const ext = URI.Utils.extname(uri).toLowerCase().replace('.', '');
const insertAsMedia = typeof options?.insertAsMedia === 'undefined' ? mediaFileExtensions.has(ext) : !!options.insertAsMedia;
const insertAsVideo = mediaFileExtensions.get(ext) === MediaKind.Video;
const insertAsAudio = mediaFileExtensions.get(ext) === MediaKind.Audio;

if (insertAsVideo) {
insertedImageCount++;
snippet.appendText(`<video src="${mdPath}" controls title="`);
snippet.appendPlaceholder('Title');
snippet.appendText('"></video>');
} else if (insertAsAudio) {
insertedImageCount++;
snippet.appendText(`<audio src="${mdPath}" controls title="`);
snippet.appendPlaceholder('Title');
snippet.appendText('"></audio>');
} else {
if (insertAsMedia) {
insertedImageCount++;
Expand Down