Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F10 keybinding for debugger step, even on Web. #183510

Merged
merged 1 commit into from May 27, 2023

Conversation

rehmsen
Copy link
Contributor

@rehmsen rehmsen commented May 26, 2023

Fixes #181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was believed that F10 could not be bound on browsers. This turned out to be incorrect, so we make the shortcut consistent (F10) with desktop VSCode which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience some web users may have gotten used to by now.

Fixes microsoft#181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was
believed that F10 could not be bound on browsers. This turned out to be
incorrect, so we make the shortcut consistent (F10) with desktop VSCode
which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience
some web users may have gotten used to by now.
@roblourens roblourens added this to the May 2023 milestone May 26, 2023
@roblourens roblourens enabled auto-merge (squash) May 26, 2023 23:53
@roblourens roblourens merged commit dbead18 into microsoft:main May 27, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider using F10 for debugger step over, even with isWeb
3 participants