Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve winpty/conpty name in process explorer #183726

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Improve winpty/conpty name in process explorer #183726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/vs/base/node/ps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,23 @@ export function listProcesses(rootPid: number): Promise<ProcessItem> {
const UTILITY_NETWORK_HINT = /--utility-sub-type=network/i;
const NODEJS_PROCESS_HINT = /--ms-enable-electron-run-as-node/i;
const WINDOWS_CRASH_REPORTER = /--crashes-directory/i;
const WINDOWS_PTY = /\\pipe\\winpty-control/i;
const WINDOWS_CONSOLE_HOST = /conhost\.exe/i;
const WINPTY = /\\pipe\\winpty-control/i;
const CONPTY = /conhost\.exe.+--headless/i;
const TYPE = /--type=([a-zA-Z-]+)/;

// find windows crash reporter
if (WINDOWS_CRASH_REPORTER.exec(cmd)) {
return 'electron-crash-reporter';
}

// find windows pty process
if (WINDOWS_PTY.exec(cmd)) {
return 'winpty-process';
// find winpty process
if (WINPTY.exec(cmd)) {
return 'winpty-agent';
}

// find windows console host process
if (WINDOWS_CONSOLE_HOST.exec(cmd)) {
return 'console-window-host (Windows internal process)';
// find conpty process
if (CONPTY.exec(cmd)) {
return 'conpty-agent';
}

// find "--type=xxxx"
Expand Down