Use a better id for QuickPickList #184733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
previously approved these changes
Jun 9, 2023
Using saneLabel before is computationally more intense then just checking a few properties. Additionally, this wasn't taking into account the `id`. So this change is not only faster, but also more accurate! ref #184615
TylerLeonhardt
force-pushed
the
tyler/spotty-roundworm
branch
from
1d9d58c
to
7ceb99e
Compare
rzhao271
approved these changes
Jun 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using saneLabel before is computationally more intense then just checking a few properties. Additionally, this wasn't taking into account the
id.So this change is not only faster, but also more accurate!
ref #184615