Remove side effect from array.some callback

[CGNonofr]

some method callback is supposed to be side-effect free. Also, findIndex is now well supported

[Tyriar]

The change looks good, but I'm missing where the side effect is?

[CGNonofr]

The index variable is declared outside of the callback and modified inside the callback

[Tyriar]

Oh I thought you meant _getTerminalObjectIndexById has a side effect. I wouldn't call .some setting some value outside it's callback a problem, it's basically the same thing as doing it with a for loop. Regardless, the code looks better with your changes so thanks 🙂

[CGNonofr]

Oh I thought you meant _getTerminalObjectIndexById has a side effect. I wouldn't call .some setting some value outside it's callback a problem, it's basically the same thing as doing it with a for loop. Regardless, the code looks better with your changes so thanks slightly_smiling_face

It's a problem it you want to tree-shake the code and expect calls to some to be side-effect free