Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait 5 seconds before initiating pending cue #185792

Merged
merged 4 commits into from
Jun 21, 2023
Merged

wait 5 seconds before initiating pending cue #185792

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab43727
wait 5 seconds before initiating pending cue
meganrogge Jun 21, 2023
6c62f73
rm comments
meganrogge Jun 21, 2023
1c78f2e
rm unnecessary async
meganrogge Jun 21, 2023
36fc6be
disposable timeout
meganrogge Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/vs/workbench/contrib/chat/browser/chatWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import * as dom from 'vs/base/browser/dom';
import { status } from 'vs/base/browser/ui/aria/aria';
import { ITreeContextMenuEvent, ITreeElement } from 'vs/base/browser/ui/tree/tree';
import { disposableTimeout } from 'vs/base/common/async';
import { CancellationToken } from 'vs/base/common/cancellation';
import { Emitter } from 'vs/base/common/event';
import { Disposable, DisposableStore, IDisposable, combinedDisposable, toDisposable } from 'vs/base/common/lifecycle';
Expand Down Expand Up @@ -526,22 +527,29 @@ export class ChatAccessibilityService extends Disposable implements IChatAccessi
declare readonly _serviceBrand: undefined;

private _responsePendingAudioCue: IDisposable | undefined;
private _hasReceivedRequest: boolean = false;

constructor(@IAudioCueService private readonly _audioCueService: IAudioCueService) {
super();
}
acceptRequest(): void {
this._audioCueService.playAudioCue(AudioCue.chatRequestSent, true);
this._responsePendingAudioCue = this._audioCueService.playAudioCueLoop(AudioCue.chatResponsePending, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS);
this._register(disposableTimeout(() => {
if (!this._hasReceivedRequest) {
this._responsePendingAudioCue = this._audioCueService.playAudioCueLoop(AudioCue.chatResponsePending, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS);
}
}, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS));
}
acceptResponse(response?: IChatResponseViewModel): void {
this._hasReceivedRequest = true;
this._responsePendingAudioCue?.dispose();
this._audioCueService.playRandomAudioCue(AudioCueGroupId.chatResponseReceived, true);
if (!response) {
return;
}
const errorDetails = response.errorDetails ? ` ${response.errorDetails.message}` : '';
status(response.response.value + errorDetails);
this._hasReceivedRequest = false;
}
}