Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new audio cues, set in progress one to auto by default #186030

Merged
merged 2 commits into from
Jun 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/vs/platform/audioCues/browser/audioCueService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ export class Sound {
public static readonly chatResponseReceived2 = Sound.register({ fileName: 'chatResponseReceived2.mp3' });
public static readonly chatResponseReceived3 = Sound.register({ fileName: 'chatResponseReceived3.mp3' });
public static readonly chatResponseReceived4 = Sound.register({ fileName: 'chatResponseReceived4.mp3' });
public static readonly chatResponseReceived5 = Sound.register({ fileName: 'chatResponseReceived5.mp3' });

private constructor(public readonly fileName: string) { }
}
Expand Down Expand Up @@ -380,11 +379,6 @@ export class AudioCue {
...this.chatResponseReceived
});

public static readonly chatResponseReceived5 = AudioCue.register({
sound: Sound.chatResponseReceived5,
...this.chatResponseReceived
});

public static readonly chatResponsePending = AudioCue.register({
name: localize('audioCues.chatResponsePending', 'Chat Response Pending'),
sound: Sound.chatResponsePending,
Expand Down
Binary file modified src/vs/platform/audioCues/browser/media/chatRequestSent.mp3
Binary file not shown.
Binary file modified src/vs/platform/audioCues/browser/media/chatResponsePending.mp3
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).regis
'audioCues.chatResponsePending': {
'description': localize('audioCues.chatResponsePending', "Plays a sound on loop while the response is pending."),
...audioCueFeatureBase,
default: 'off'
default: 'auto'
},
'audioCues.chatResponseReceived': {
'description': localize('audioCues.chatResponseReceived', "Plays a sound on loop while the response has been received."),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function getAccessibilityHelpText(accessor: ServicesAccessor, type: 'pane
content.push(localize('inlineChat.explain', "When a request is prefixed with /explain, a response will explain the code in the current selection and the chat view will be focused."));
content.push(localize('inlineChat.toolbar', "Use tab to reach conditional parts like commands, status, message responses and more."));
}
content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat."));
content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat. By default, if a request takes more than 5 seconds, you will hear an audio cue indicating that progress is still occurring."));
return content.join('\n');
}

Expand Down