Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always respect non-empty selection in getMultiSelectedEditorContexts #187704

Merged
merged 1 commit into from Aug 3, 2023
Merged

Always respect non-empty selection in getMultiSelectedEditorContexts #187704

merged 1 commit into from Aug 3, 2023

Conversation

hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Jul 12, 2023

Fix #186892

@hsfzxjy hsfzxjy force-pushed the open-editors-multiselect-186892 branch 3 times, most recently from 6ecf1ae to 697323b Compare July 18, 2023 06:04
@hsfzxjy hsfzxjy force-pushed the open-editors-multiselect-186892 branch from 697323b to c5244af Compare July 19, 2023 06:11
@lramos15 lramos15 added this to the August 2023 milestone Aug 2, 2023
@lramos15 lramos15 merged commit 4df2340 into microsoft:main Aug 3, 2023
6 checks passed
@lramos15
Copy link
Member

lramos15 commented Aug 3, 2023

Thanks!

@hsfzxjy hsfzxjy deleted the open-editors-multiselect-186892 branch August 8, 2023 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2023
@bpasero
Copy link
Member

bpasero commented Sep 21, 2023

Fyi I think this causes #193574

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

@lramos15 lramos15

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Multiselection in open editors is badly managed
4 participants
@hsfzxjy @lramos15 @bpasero @roblourens