Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline chat - workaround not being able to hide all lines of an editor #187836

Merged
merged 1 commit into from
Jul 13, 2023
Merged

inline chat - workaround not being able to hide all lines of an editor #187836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/vs/workbench/contrib/inlineChat/browser/inlineChatLivePreviewWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,15 +307,22 @@ export class InlineChatLivePreviewWidget extends ZoneWidget {
}

private _hideEditorRanges(editor: ICodeEditor, lineRanges: LineRange[]): void {
assertType(editor.hasModel());

lineRanges = lineRanges.filter(range => !range.isEmpty);
if (lineRanges.length === 0) {
// todo?
this._logService.debug(`[IE] diff NOTHING to hide for ${editor.getId()} with ${String(editor.getModel()?.uri)}`);
return;
}
const ranges = lineRanges.map(lineRangeAsRange);
editor.setHiddenAreas(ranges, InlineChatLivePreviewWidget._hideId);
this._logService.debug(`[IE] diff HIDING ${ranges} for ${editor.getId()} with ${String(editor.getModel()?.uri)}`);

let hiddenRanges = lineRanges.map(lineRangeAsRange);
if (LineRange.fromRange(hiddenRanges.reduce(Range.plusRange)).equals(LineRange.ofLength(1, editor.getModel().getLineCount()))) {
// TODO not every line can be hidden, keep the first line around
hiddenRanges = [editor.getModel().getFullModelRange().delta(1)];
}
editor.setHiddenAreas(hiddenRanges, InlineChatLivePreviewWidget._hideId);
this._logService.debug(`[IE] diff HIDING ${hiddenRanges} for ${editor.getId()} with ${String(editor.getModel()?.uri)}`);
}

protected override revealRange(range: Range, isLastLine: boolean): void {
Expand Down