-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support transferring input placeholder across workspaces #188415
Conversation
51c2644
to
1358b5e
Compare
1358b5e
to
e801256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, IMHO there's no current need to support customizing the input value in the transfer state, we should add that later if we end up needing it
@@ -93,7 +93,7 @@ declare module 'vscode' { | |||
export interface InteractiveSession { | |||
requester: InteractiveSessionParticipantInformation; | |||
responder: InteractiveSessionParticipantInformation; | |||
inputPlaceholder?: string; | |||
inputValue?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this property in use somewhere? We should be careful not to break existing extension consumers
Changed to saving the input in the chat model itself: |
Fixes:
In the /createWorkspace scenario, creating and opening a new workspace does not pre-populate the slash command since the input view state is not transferred across workspaces.