Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recently-broken cleanup of obsolete (superseded) extension folders #189335

Merged
merged 1 commit into from Aug 2, 2023
Merged

Fix recently-broken cleanup of obsolete (superseded) extension folders #189335

merged 1 commit into from Aug 2, 2023

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #189334

@andreamah I think the fix deserves to be a candidate for upcoming 1.81

@gjsjohnmurray
Copy link
Contributor Author

/assign @sandy081

@andreamah andreamah requested a review from sandy081 July 31, 2023 17:04
@andreamah andreamah requested a review from alexdima August 1, 2023 16:31
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Aug 2, 2023
alexdima
alexdima approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexdima alexdima added this to the August 2023 milestone Aug 2, 2023
@alexdima alexdima removed the request for review from sandy081 August 2, 2023 08:12
@alexdima alexdima merged commit 605fa78 into microsoft:main Aug 2, 2023
6 checks passed
@alexdima alexdima removed the candidate Issue identified as probable candidate for fixing in the next release label Aug 2, 2023
@alexdima alexdima mentioned this pull request Aug 2, 2023
Merged
alexdima pushed a commit that referenced this pull request Aug 2, 2023
@gjsjohnmurray @alexdima
Fix recently-broken cleanup of obsolete (superseded) extension folders (
ce3f7b8 
#189335)
alexdima added a commit that referenced this pull request Aug 2, 2023
@alexdima @gjsjohnmurray
Fix recently-broken cleanup of obsolete (superseded) extension folders (
8364f76 
#189456)

Fix recently-broken cleanup of obsolete (superseded) extension folders (#189335)

Co-authored-by: John Murray <johnm@georgejames.com>
@gjsjohnmurray gjsjohnmurray deleted the fix-189334 branch August 2, 2023 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Insiders is no longer removing obsolete (superseded) extension folders
4 participants
@gjsjohnmurray @alexdima @rzhao271 @sandy081