Guard $IsWindows
#190192
Merged
Guard $IsWindows
#190192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it works with PowerShell 5.1.
|
@meganrogge @Tyriar how would I go about checking that the escape sequence is now being emitted correctly? |
syedsadiqali
approved these changes
Aug 11, 2023
|
@andyleejordan set log level to trace then open Output > Terminal. You should see this when you create a terminal:
|
Tyriar
requested changes
Aug 11, 2023
alexdima
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it works with PowerShell 5.1.
Probably resolves #190103. I just edited in the browser so haven't tested...