Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow of setting list #190721

Merged
merged 1 commit into from Aug 18, 2023
Merged

Fix overflow of setting list #190721

merged 1 commit into from Aug 18, 2023

Conversation

hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Aug 18, 2023

Fix #190720

@rzhao271 rzhao271 self-requested a review August 18, 2023 16:39
@rzhao271 rzhao271 added this to the August 2023 milestone Aug 18, 2023
@rzhao271
Copy link
Contributor

Fixes #187467

rzhao271
rzhao271 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rzhao271 rzhao271 merged commit 967f27b into microsoft:main Aug 18, 2023
6 checks passed
@hsfzxjy hsfzxjy deleted the settings-list-overflow-190720 branch August 19, 2023 01:46
Krzysztof-Cieslak pushed a commit to githubnext/vscode that referenced this pull request Sep 18, 2023
@hsfzxjy @Krzysztof-Cieslak
Fix overflow of setting list (microsoft#190721)
6f29f7f 
Don't set height for AbstractListSettingWidget

Fixes microsoft#187467
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Settings list item wrapping towards next line causes the list to overflow
3 participants
@hsfzxjy @rzhao271 @Tyriar