Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves diffing #190994

Merged
merged 1 commit into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/vs/editor/common/diff/algorithms/joinSequenceDiffs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,29 @@ export function removeRandomMatches(sequence1: LinesSliceCharSequence, sequence2
diffs = result;
} while (counter++ < 10 && shouldRepeat);

// Remove short suffixes/prefixes
for (let i = 0; i < diffs.length; i++) {
const cur = diffs[i];

let range1 = cur.seq1Range;
let range2 = cur.seq2Range;

const fullRange1 = sequence1.extendToFullLines(cur.seq1Range);
const prefix = sequence1.getText(new OffsetRange(fullRange1.start, cur.seq1Range.start));
if (prefix.length > 0 && prefix.trim().length <= 3 && cur.seq1Range.length + cur.seq2Range.length > 100) {
range1 = cur.seq1Range.deltaStart(-prefix.length);
range2 = cur.seq2Range.deltaStart(-prefix.length);
}

const suffix = sequence1.getText(new OffsetRange(cur.seq1Range.endExclusive, fullRange1.endExclusive));
if (suffix.length > 0 && (suffix.trim().length <= 3 && cur.seq1Range.length + cur.seq2Range.length > 150)) {
range1 = range1.deltaEnd(suffix.length);
range2 = range2.deltaEnd(suffix.length);
}

diffs[i] = new SequenceDiff(range1, range2);
}

return diffs;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"modifiedRange": "[29,37)",
"innerChanges": [
{
"originalRange": "[29,1 -> 60,48]",
"modifiedRange": "[29,1 -> 36,66]"
"originalRange": "[29,1 -> 61,1]",
"modifiedRange": "[29,1 -> 37,1]"
}
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"modifiedRange": "[6,11)",
"innerChanges": [
{
"originalRange": "[6,2 -> 11,49]",
"modifiedRange": "[6,2 -> 6,91]"
"originalRange": "[6,1 -> 11,49]",
"modifiedRange": "[6,1 -> 6,91]"
},
{
"originalRange": "[12,76 -> 12,76]",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"modifiedRange": "[53,6 -> 53,45]"
},
{
"originalRange": "[52,77 -> 55,53]",
"modifiedRange": "[53,98 -> 65,66]"
"originalRange": "[52,77 -> 56,1]",
"modifiedRange": "[53,98 -> 66,1]"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"modifiedRange": "[8,12)",
"innerChanges": [
{
"originalRange": "[11,10 -> 20,25]",
"modifiedRange": "[8,10 -> 11,51]"
"originalRange": "[11,10 -> 21,1]",
"modifiedRange": "[8,10 -> 12,1]"
}
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"modifiedRange": "[14,18)",
"innerChanges": [
{
"originalRange": "[14,120 -> 14,211]",
"modifiedRange": "[14,120 -> 17,1]"
"originalRange": "[14,120 -> 15,1]",
"modifiedRange": "[14,120 -> 18,1]"
}
]
},
Expand All @@ -65,8 +65,8 @@
"modifiedRange": "[21,18 -> 21,43]"
},
{
"originalRange": "[17,71 -> 23,4]",
"modifiedRange": "[21,74 -> 21,81]"
"originalRange": "[17,71 -> 24,1]",
"modifiedRange": "[21,74 -> 22,1]"
}
]
},
Expand All @@ -93,8 +93,8 @@
"modifiedRange": "[26,38)",
"innerChanges": [
{
"originalRange": "[28,1 -> 30,31]",
"modifiedRange": "[26,1 -> 37,9]"
"originalRange": "[28,1 -> 31,1]",
"modifiedRange": "[26,1 -> 38,1]"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"modifiedRange": "[17,80)",
"innerChanges": [
{
"originalRange": "[13,10 -> 14,43]",
"modifiedRange": "[17,10 -> 79,2]"
"originalRange": "[13,10 -> 15,1]",
"modifiedRange": "[17,10 -> 80,1]"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"modifiedRange": "[9,15)",
"innerChanges": [
{
"originalRange": "[9,124 -> 9,124]",
"modifiedRange": "[9,124 -> 14,143]"
"originalRange": "[9,124 -> 10,1]",
"modifiedRange": "[9,124 -> 15,1]"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"modifiedRange": "[7,18)",
"innerChanges": [
{
"originalRange": "[7,5 -> 12,17]",
"modifiedRange": "[7,5 -> 16,7]"
"originalRange": "[7,1 -> 13,1]",
"modifiedRange": "[7,1 -> 17,1]"
},
{
"originalRange": "[13,6 -> 13,11]",
Expand Down