Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localize string typo #191046

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix: localize string typo #191046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d3065
fix: localize string typo
0o001 Aug 23, 2023
d227856
fix: suffix typo
0o001 Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/extensions/browser/extensionsViews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,7 +1431,7 @@ export function getAriaLabelForExtension(extension: IExtension | null): string {
if (!extension) {
return '';
}
const publisher = extension.publisherDomain?.verified ? localize('extension.arialabel.verifiedPublihser', "Verified Publisher {0}", extension.publisherDisplayName) : localize('extension.arialabel.publihser', "Publisher {0}", extension.publisherDisplayName);
const publisher = extension.publisherDomain?.verified ? localize('extension.arialabel.verifiedPublisher', "Verified Publisher {0}", extension.publisherDisplayName) : localize('extension.arialabel.publisher', "Publisher {0}", extension.publisherDisplayName);
const deprecated = extension?.deprecationInfo ? localize('extension.arialabel.deprecated', "Deprecated") : '';
const rating = extension?.rating ? localize('extension.arialabel.rating', "Rated {0} out of 5 stars by {1} users", extension.rating.toFixed(2), extension.ratingCount) : '';
return `${extension.displayName}, ${deprecated ? `${deprecated}, ` : ''}${extension.version}, ${publisher}, ${extension.description} ${rating ? `, ${rating}` : ''}`;
Expand Down
14 changes: 7 additions & 7 deletions src/vs/workbench/contrib/files/browser/views/explorerViewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,11 +1391,11 @@ export class FileDragAndDrop implements ITreeDragAndDrop<ExplorerItem> {
const resourceEdit = new ResourceFileEdit(resource, newResource, { copy: true, overwrite: allowOverwrite });
resourceFileEdits.push(resourceEdit);
}
const labelSufix = getFileOrFolderLabelSufix(sources);
const labelSuffix = getFileOrFolderLabelSuffix(sources);
await this.explorerService.applyBulkEdit(resourceFileEdits, {
confirmBeforeUndo: explorerConfig.confirmUndo === UndoConfirmLevel.Default || explorerConfig.confirmUndo === UndoConfirmLevel.Verbose,
undoLabel: localize('copy', "Copy {0}", labelSufix),
progressLabel: localize('copying', "Copying {0}", labelSufix),
undoLabel: localize('copy', "Copy {0}", labelSuffix),
progressLabel: localize('copying', "Copying {0}", labelSuffix),
});

const editors = resourceFileEdits.filter(edit => {
Expand All @@ -1410,11 +1410,11 @@ export class FileDragAndDrop implements ITreeDragAndDrop<ExplorerItem> {

// Do not allow moving readonly items
const resourceFileEdits = sources.filter(source => !source.isReadonly).map(source => new ResourceFileEdit(source.resource, joinPath(target.resource, source.name)));
const labelSufix = getFileOrFolderLabelSufix(sources);
const labelSuffix = getFileOrFolderLabelSuffix(sources);
const options = {
confirmBeforeUndo: this.configurationService.getValue<IFilesConfiguration>().explorer.confirmUndo === UndoConfirmLevel.Verbose,
undoLabel: localize('move', "Move {0}", labelSufix),
progressLabel: localize('moving', "Moving {0}", labelSufix)
undoLabel: localize('move', "Move {0}", labelSuffix),
progressLabel: localize('moving', "Moving {0}", labelSuffix)
};

try {
Expand Down Expand Up @@ -1518,7 +1518,7 @@ export class ExplorerCompressionDelegate implements ITreeCompressionDelegate<Exp
}
}

function getFileOrFolderLabelSufix(items: ExplorerItem[]): string {
function getFileOrFolderLabelSuffix(items: ExplorerItem[]): string {
if (items.length === 1) {
return items[0].name;
}
Expand Down