Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc PR feedback for chatWidget #191432

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Misc PR feedback for chatWidget #191432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/contrib/chat/browser/chatWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,6 @@ export class ChatWidget extends Disposable implements IChatWidget {
const mutableDisposable = this._register(new MutableDisposable());
this._register(this.tree.onDidScroll((e) => {
mutableDisposable.value = dom.scheduleAtNextAnimationFrame(() => {
mutableDisposable.dispose();
if (!e.scrollTopChanged || e.heightChanged || e.scrollHeightChanged) {
return;
}
Expand All @@ -548,8 +547,9 @@ export class ChatWidget extends Disposable implements IChatWidget {
}

const newHeight = Math.min(renderHeight + diff, maxHeight);
const inputPartHeight = this.inputPart.layout(newHeight, this.container.offsetWidth);
this.layout(newHeight + inputPartHeight, this.container.offsetWidth);
const width = this.bodyDimension?.width ?? this.container.offsetWidth;
const inputPartHeight = this.inputPart.layout(newHeight, width);
this.layout(newHeight + inputPartHeight, width);
});
}));
}
Expand Down
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/chat/browser/media/chat.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@

.quick-input-widget .interactive-session .interactive-input-and-execute-toolbar {
margin: 0;
border-radius: 2px;
}

/* #endregion */
Expand Down