Workaround slow update webgl issue on Windows #191795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deepak1556 oh I think I see this on Linux, I guess I'll remove the isWindows check:
|
connor4312
approved these changes
Aug 30, 2023
|
Yup the gl debug extension is good for desktop as well 👍
Most of the time hw acceleration is disabled in the runtime for Linux so we always end up using the swiftshader software compositing path, so yeah the fallback check would work for this case as well. The bug in chromium is at the ANGLE vulkan GL renderer which can affect both Linux and Windows. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190195
@deepak1556 I want to make sure this is still good on desktop, not using the
appbased detection you mentioned.