Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debt - ensure to close state service #192850

Merged
merged 1 commit into from
Sep 12, 2023
Merged

debt - ensure to close state service #192850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/vs/platform/state/test/node/state.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.setItems.key3'), undefined);
assert.strictEqual(service.getItem('some.setItems.key4'), undefined);
assert.strictEqual(service.getItem('some.setItems.key5'), undefined);

return service.close();
});

test('Multiple ops are buffered and applied', async function () {
Expand Down Expand Up @@ -199,6 +201,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.key2'), 'some.value2');
assert.strictEqual(service.getItem('some.key3'), 'some.value3');
assert.strictEqual(service.getItem('some.key4'), undefined);

return service.close();
});

test('Multiple ops (Immediate Strategy)', async function () {
Expand Down Expand Up @@ -228,6 +232,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.key2'), 'some.value2');
assert.strictEqual(service.getItem('some.key3'), 'some.value3');
assert.strictEqual(service.getItem('some.key4'), undefined);

return service.close();
});

test('Used before init', async function () {
Expand All @@ -253,6 +259,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.key2'), 'some.value2');
assert.strictEqual(service.getItem('some.key3'), 'some.value3');
assert.strictEqual(service.getItem('some.key4'), undefined);

return service.close();
});

test('Used after close', async function () {
Expand All @@ -276,7 +284,7 @@ flakySuite('StateService', () => {
assert.ok(contents.includes('some.value1'));
assert.ok(!contents.includes('some.marker'));

await service.close();
return service.close();
});

test('Closed before init', async function () {
Expand Down