Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not compute sha1 for large files #194404

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Do not compute sha1 for large files #194404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
54 changes: 39 additions & 15 deletions src/vs/editor/common/services/modelService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,6 @@ function MODEL_ID(resource: URI): string {
return resource.toString();
}

function computeModelSha1(model: ITextModel): string {
// compute the sha1
const shaComputer = new StringSHA1();
const snapshot = model.createSnapshot();
let text: string | null;
while ((text = snapshot.read())) {
shaComputer.update(text);
}
return shaComputer.digest();
}

class ModelData implements IDisposable {

private readonly _modelEventListeners = new DisposableStore();
Expand Down Expand Up @@ -337,7 +326,12 @@ export class ModelService extends Disposable implements IModelService {
if (resource && this._disposedModels.has(MODEL_ID(resource))) {
const disposedModelData = this._removeDisposedModel(resource)!;
const elements = this._undoRedoService.getElements(resource);
const sha1IsEqual = (computeModelSha1(model) === disposedModelData.sha1);
const sha1Computer = this._getSHA1Computer();
const sha1IsEqual = (
sha1Computer.canComputeSHA1(model)
? sha1Computer.computeSHA1(model) === disposedModelData.sha1
: false
);
if (sha1IsEqual || disposedModelData.sharesUndoRedoStack) {
for (const element of elements.past) {
if (isEditStackElement(element) && element.matchesResource(resource)) {
Expand Down Expand Up @@ -535,15 +529,16 @@ export class ModelService extends Disposable implements IModelService {
}

const maxMemory = ModelService.MAX_MEMORY_FOR_CLOSED_FILES_UNDO_STACK;
const sha1Computer = this._getSHA1Computer();
if (!maintainUndoRedoStack) {
if (!sharesUndoRedoStack) {
const initialUndoRedoSnapshot = modelData.model.getInitialUndoRedoSnapshot();
if (initialUndoRedoSnapshot !== null) {
this._undoRedoService.restoreSnapshot(initialUndoRedoSnapshot);
}
}
} else if (!sharesUndoRedoStack && heapSize > maxMemory) {
// the undo stack for this file would never fit in the configured memory, so don't bother with it.
} else if (!sharesUndoRedoStack && (heapSize > maxMemory || !sha1Computer.canComputeSHA1(model))) {
// the undo stack for this file would never fit in the configured memory or the file is very large, so don't bother with it.
const initialUndoRedoSnapshot = modelData.model.getInitialUndoRedoSnapshot();
if (initialUndoRedoSnapshot !== null) {
this._undoRedoService.restoreSnapshot(initialUndoRedoSnapshot);
Expand All @@ -552,7 +547,7 @@ export class ModelService extends Disposable implements IModelService {
this._ensureDisposedModelsHeapSize(maxMemory - heapSize);
// We only invalidate the elements, but they remain in the undo-redo service.
this._undoRedoService.setElementsValidFlag(model.uri, false, (element) => (isEditStackElement(element) && element.matchesResource(model.uri)));
this._insertDisposedModel(new DisposedModelInfo(model.uri, modelData.model.getInitialUndoRedoSnapshot(), Date.now(), sharesUndoRedoStack, heapSize, computeModelSha1(model), model.getVersionId(), model.getAlternativeVersionId()));
this._insertDisposedModel(new DisposedModelInfo(model.uri, modelData.model.getInitialUndoRedoSnapshot(), Date.now(), sharesUndoRedoStack, heapSize, sha1Computer.computeSHA1(model), model.getVersionId(), model.getAlternativeVersionId()));
}

delete this._models[modelId];
Expand All @@ -572,4 +567,33 @@ export class ModelService extends Disposable implements IModelService {
ModelService._setModelOptionsForModel(model, newOptions, oldOptions);
this._onModelModeChanged.fire({ model, oldLanguageId: oldLanguageId });
}

protected _getSHA1Computer(): ITextModelSHA1Computer {
return new DefaultModelSHA1Computer();
}
}

export interface ITextModelSHA1Computer {
canComputeSHA1(model: ITextModel): boolean;
computeSHA1(model: ITextModel): string;
}

export class DefaultModelSHA1Computer implements ITextModelSHA1Computer {

public static MAX_MODEL_SIZE = 10 * 1024 * 1024; // takes 200ms to compute a sha1 on a 10MB model on a new machine

canComputeSHA1(model: ITextModel): boolean {
return (model.getValueLength() <= DefaultModelSHA1Computer.MAX_MODEL_SIZE);
}

computeSHA1(model: ITextModel): string {
// compute the sha1
const shaComputer = new StringSHA1();
const snapshot = model.createSnapshot();
let text: string | null;
while ((text = snapshot.read())) {
shaComputer.update(text);
}
return shaComputer.digest();
}
}