mapped edits: support de/serialization of mapped edits context so that it can be used across vscode sessions #194572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Oct 2, 2023
jrieken
previously approved these changes
Oct 2, 2023
especially because `isResponse` may've been incorrect because it would return true on a falsy value while `isRequest` checked for it
ulugbekna
force-pushed
the
ulugbekna/code-mappers-context-serialization
branch
from
fc76932
to
f1f64c8
Compare
|
CI was failing because of a snapshot testing bug which was fixed on latest main. Rebased and force pushed (sorry, should've rather created a merge commit (?)) |
roblourens
previously approved these changes
Oct 2, 2023
…t it can be used across vscode sessions reservation/concern: the document versions are obsolete/incorrect, what should we do with them?
ulugbekna
force-pushed
the
ulugbekna/code-mappers-context-serialization
branch
from
f1f64c8
to
139e06a
Compare
ulugbekna
force-pushed
the
ulugbekna/code-mappers-context-serialization
branch
from
3e2b6d6
to
d32f680
Compare
jrieken
approved these changes
Oct 3, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
…t it can be used across vscode sessions (microsoft#194572) * refactor(chatModel): remove unused code especially because `isResponse` may've been incorrect because it would return true on a falsy value while `isRequest` checked for it * refactor(mapped edits): better names * mapped edits: support de/serialization of mapped edits context so that it can be used across vscode sessions reservation/concern: the document versions are obsolete/incorrect, what should we do with them? * mapped edits: fix test failing remotely but not locally
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reservation/concern: the document versions are obsolete/incorrect, what should we do with them?
@roblourens @jrieken would appreciate if you could have a look, thanks heaps!