Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a hotkey that works with the screen reader optimize mode #194754

Merged
merged 1 commit into from
Oct 4, 2023
Merged

add a hotkey that works with the screen reader optimize mode #194754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/vs/workbench/contrib/notebook/browser/contrib/navigation/arrow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,13 @@ registerAction2(class FocusNextCellAction extends NotebookCellAction {
),
primary: KeyCode.DownArrow,
weight: KeybindingWeight.EditorCore
}
},
{
when: NOTEBOOK_EDITOR_FOCUSED,
primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown,
mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, },
weight: KeybindingWeight.WorkbenchContrib
},
]
});
}
Expand Down Expand Up @@ -181,7 +187,13 @@ registerAction2(class FocusPreviousCellAction extends NotebookCellAction {
),
primary: KeyCode.UpArrow,
weight: KeybindingWeight.WorkbenchContrib, // markdown keybinding, focus on list: higher weight to override list.focusDown
}
},
{
when: NOTEBOOK_EDITOR_FOCUSED,
primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageUp,
mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageUp },
weight: KeybindingWeight.WorkbenchContrib
},
],
});
}
Expand Down
8 changes: 7 additions & 1 deletion src/vs/workbench/contrib/notebook/browser/notebookAccessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ export function getAccessibilityHelpText(accessor: ServicesAccessor): string {
content.push(descriptionForCommand('notebook.cell.focusInOutput',
localize('notebook.cell.focusInOutput', 'The Focus Output command ({0}) will set focus in the cell\'s output.'),
localize('notebook.cell.focusInOutputNoKb', 'The Quit Edit command will set focus in the cell\'s output and is currently not triggerable by a keybinding.'), keybindingService));
content.push(localize('notebook.cellNavigation', 'The up and down arrows will move focus between cells while focused on the outer cell container'));
content.push(descriptionForCommand('notebook.focusNextEditor',
localize('notebook.focusNextEditor', 'The Focus Next Cell Editor command ({0}) will set focus in the next cell\'s editor.'),
localize('notebook.focusNextEditorNoKb', 'The Focus Next Cell Editor command will set focus in the next cell\'s editor and is currently not triggerable by a keybinding.'), keybindingService));
content.push(descriptionForCommand('notebook.focusPreviousEditor',
localize('notebook.focusPreviousEditor', 'The Focus Previous Cell Editor command ({0}) will set focus in the previous cell\'s editor.'),
localize('notebook.focusPreviousEditorNoKb', 'The Focus Previous Cell Editor command will set focus in the previous cell\'s editor and is currently not triggerable by a keybinding.'), keybindingService));
content.push(localize('notebook.cellNavigation', 'The up and down arrows will also move focus between cells while focused on the outer cell container.'));
content.push(descriptionForCommand('notebook.cell.executeAndFocusContainer',
localize('notebook.cell.executeAndFocusContainer', 'The Execute Cell command ({0}) executes the cell that currently has focus.',),
localize('notebook.cell.executeAndFocusContainerNoKb', 'The Execute Cell command executes the cell that currently has focus and is currently not triggerable by a keybinding.'), keybindingService));
Expand Down