Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a minimum chat response render rate #195667

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add a minimum chat response render rate #195667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/vs/workbench/contrib/chat/browser/chatListRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,13 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
}

if (element.contentUpdateTimings && element.contentUpdateTimings.impliedWordLoadRate) {
const minRate = 12;
// This doesn't account for dead time after the last update. When the previous update is the final one and the model is only waiting for followupQuestions, that's good.
// When there was one quick update and then you are waiting longer for the next one, that's not good since the rate should be decreasing.
// If it's an issue, we can change this to be based on the total time from now to the beginning.
const rateBoost = 1.5;
return element.contentUpdateTimings.impliedWordLoadRate * rateBoost;
const rate = element.contentUpdateTimings.impliedWordLoadRate * rateBoost;
return Math.max(rate, minRate);
}

return 8;
Expand Down