Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM - optimize tree rendering when having multiple repositories #198150

Merged
merged 1 commit into from
Nov 13, 2023
Merged

SCM - optimize tree rendering when having multiple repositories #198150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/vs/workbench/contrib/scm/browser/scmViewPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2660,11 +2660,11 @@ export class SCMViewPane extends ViewPane {
for (const repository of added) {
const repositoryDisposables = new DisposableStore();

repositoryDisposables.add(repository.provider.onDidChange(() => this.updateChildren()));
repositoryDisposables.add(repository.input.onDidChangeActionButton(() => this.updateChildren()));
repositoryDisposables.add(repository.input.onDidChangeVisibility(() => this.updateChildren()));
repositoryDisposables.add(repository.provider.onDidChange(() => this.updateChildren(repository)));
repositoryDisposables.add(repository.input.onDidChangeActionButton(() => this.updateChildren(repository)));
repositoryDisposables.add(repository.input.onDidChangeVisibility(() => this.updateChildren(repository)));
repositoryDisposables.add(repository.provider.onDidChangeResourceGroups(() => {
this.updateChildren();
this.updateChildren(repository);
this.onDidActiveEditorChange();
}));

Expand All @@ -2681,9 +2681,9 @@ export class SCMViewPane extends ViewPane {
if (!resourceGroupDisposables.has(resourceGroup)) {
const disposableStore = new DisposableStore();

disposableStore.add(resourceGroup.onDidChange(() => this.updateChildren()));
disposableStore.add(resourceGroup.onDidChange(() => this.updateChildren(repository)));
disposableStore.add(resourceGroup.onDidChangeResources(() => {
this.updateChildren();
this.updateChildren(repository);
this.onDidActiveEditorChange();
}));
resourceGroupDisposables.set(resourceGroup, disposableStore);
Expand Down Expand Up @@ -2825,11 +2825,17 @@ export class SCMViewPane extends ViewPane {
this.storageService.store('scm.viewState2', JSON.stringify(this.tree.getViewState()), StorageScope.WORKSPACE, StorageTarget.MACHINE);
}

private updateChildren(element?: ISCMRepository | ISCMResourceGroup, recursive?: boolean, rerender?: boolean) {
private updateChildren(element?: ISCMRepository) {
this.asyncOperationSequencer.queue(async () => {
const focusedInput = this.inputRenderer.getFocusedInput();

await this.tree.updateChildren(element, recursive, rerender);
if (element && (this.alwaysShowRepositories || this.scmViewService.visibleRepositories.length > 1)) {
// Refresh specific repository
await this.tree.updateChildren(element);
} else {
// Refresh the entire tree
await this.tree.updateChildren();
}

if (focusedInput) {
this.inputRenderer.getRenderedInputWidget(focusedInput)?.focus();
Expand Down