Extend TextEditorLineNumbersStyle with Interval #198787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
pyrrho
force-pushed
the
TextEditorLineNumbersStyle_Interval
branch
from
7e20a86
to
d674fad
Compare
|
@hediet the code looks reasonable to me, I'll leave it to you to decide if we want to take the API change in. |
hediet
approved these changes
Jan 31, 2024
aeschli
approved these changes
Jan 31, 2024
hediet
force-pushed
the
TextEditorLineNumbersStyle_Interval
branch
from
d674fad
to
901e9d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextEditorLineNumbersStylein both extHostTypes.ts and vscode.d.ts with anIntervalmember.TextEditorLineNumbersStyle.Intervaland (the already extant)RenderLineNumbersType.Interval.MainThreadTextEditor.setConfigurationto handle{ ..., lineNumbers: 'interval' }.This should allow extensions to read from/write to
vscode.window.activeTextEditor.options.lineNumbersto detect and apply theIntervalconfiguration. This PR was tested by starting a debugging session, and modifying the above field in the Debug Console.This PR may be relevant to #85471, though that issue is closed, and was locked in January of 2022. (It says there are three comments on there, but I'm not seeing them. I'm guessing they added after the github-actions bot locked the issue and community members can't access them?)
I'd be happy to open a new issue to link this PR to if that would be helpful to the process.