Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire an input event on editor.action.clipboardPasteAction #198822

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fire an input event on editor.action.clipboardPasteAction #198822

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b552ef
Fire an input event on `editor.action.clipboardPasteAction`
a-stewart Nov 22, 2023
fad6ecf
Rename Event to BaseEvent to avoid conflict with Browser Event
a-stewart Nov 23, 2023
f9f5c9d
Specify bubbles and cancelable in the event
a-stewart Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/vs/workbench/browser/actions/textInputActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle
import { isNative } from 'vs/base/common/platform';
import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';
import { StandardMouseEvent } from 'vs/base/browser/mouseEvent';
import { Event } from 'vs/base/common/event';
import { Event as BaseEvent } from 'vs/base/common/event';

export class TextInputActionsProvider extends Disposable implements IWorkbenchContribution {

Expand Down Expand Up @@ -64,6 +64,7 @@ export class TextInputActionsProvider extends Disposable implements IWorkbenchCo
element.value = `${element.value.substring(0, selectionStart)}${clipboardText}${element.value.substring(selectionEnd, element.value.length)}`;
element.selectionStart = selectionStart + clipboardText.length;
element.selectionEnd = element.selectionStart;
element.dispatchEvent(new Event('input', { bubbles: true, cancelable: true }));
}
}
}),
Expand All @@ -77,7 +78,7 @@ export class TextInputActionsProvider extends Disposable implements IWorkbenchCo
private registerListeners(): void {

// Context menu support in input/textarea
this._register(Event.runAndSubscribe(this.layoutService.onDidAddContainer, ({ container, disposables }) => {
this._register(BaseEvent.runAndSubscribe(this.layoutService.onDidAddContainer, ({ container, disposables }) => {
disposables.add(addDisposableListener(container, 'contextmenu', e => this.onContextMenu(getWindow(container), e)));
}, { container: this.layoutService.mainContainer, disposables: this._store }));
}
Expand Down