Low hanging fruit of onboarding to ensureNoDisposablesAreLeakedInTestSuite

.eslintrc.json

@@ -199,7 +199,6 @@
 							"src/vs/base/test/common/strings.test.ts",
 							"src/vs/base/test/common/stripComments.test.ts",
 							"src/vs/base/test/common/ternarySearchtree.test.ts",
-							"src/vs/base/test/common/tfIdf.test.ts",
 							"src/vs/base/test/common/types.test.ts",
 							"src/vs/base/test/common/uri.test.ts",
 							"src/vs/base/test/common/uuid.test.ts",
@@ -208,7 +207,6 @@
 							"src/vs/base/test/node/id.test.ts",
 							"src/vs/base/test/node/nodeStreams.test.ts",
 							"src/vs/base/test/node/port.test.ts",
-							"src/vs/base/test/node/powershell.test.ts",
 							"src/vs/base/test/node/snapshot.test.ts",
 							"src/vs/base/test/node/unc.test.ts",
 							"src/vs/code/test/electron-sandbox/issue/testReporterModel.test.ts",
@@ -319,7 +317,6 @@
 							"src/vs/workbench/contrib/tasks/test/common/taskConfiguration.test.ts",
 							"src/vs/workbench/contrib/terminal/test/browser/terminalActions.test.ts",
 							"src/vs/workbench/contrib/themes/test/node/colorRegistryExport.test.ts",
-							"src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts",
 							"src/vs/workbench/contrib/welcomeGettingStarted/test/browser/gettingStartedMarkdownRenderer.test.ts",
 							"src/vs/workbench/services/commands/test/common/commandService.test.ts",
 							"src/vs/workbench/services/configuration/test/common/configurationModels.test.ts",

src/vs/base/test/common/tfIdf.test.ts

@@ -6,6 +6,7 @@
 import * as assert from 'assert';
 import { CancellationToken } from 'vs/base/common/cancellation';
 import { TfIdfCalculator, TfIdfDocument, TfIdfScore } from 'vs/base/common/tfIdf';
+import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
 
 /**
  * Generates all permutations of an array.
@@ -39,6 +40,7 @@ function assertScoreOrdersEqual(actualScores: TfIdfScore[], expectedScoreKeys: s
 }
 
 suite('TF-IDF Calculator', function () {
+	ensureNoDisposablesAreLeakedInTestSuite();
 	test('Should return no scores when no documents are given', () => {
 		const tfidf = new TfIdfCalculator();
 		const scores = tfidf.calculateScores('something', CancellationToken.None);

src/vs/base/test/node/powershell.test.ts

@@ -6,6 +6,7 @@ import * as assert from 'assert';
 import * as fs from 'fs';
 import * as platform from 'vs/base/common/platform';
 import { enumeratePowerShellInstallations, getFirstAvailablePowerShellInstallation, IPowerShellExeDetails } from 'vs/base/node/powershell';
+import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
 
 function checkPath(exePath: string) {
 	// Check to see if the path exists
@@ -28,7 +29,7 @@ function checkPath(exePath: string) {
 
 if (platform.isWindows) {
 	suite('PowerShell finder', () => {
-
+		ensureNoDisposablesAreLeakedInTestSuite();
 		test('Can find first available PowerShell', async () => {
 			const pwshExe = await getFirstAvailablePowerShellInstallation();
 			const exePath = pwshExe?.exePath;

src/vs/workbench/contrib/url/test/browser/trustedDomains.test.ts

@@ -8,6 +8,7 @@ import * as assert from 'assert';
 import { isURLDomainTrusted } from 'vs/workbench/contrib/url/browser/trustedDomainsValidator';
 import { URI } from 'vs/base/common/uri';
 import { extractGitHubRemotesFromGitConfig } from 'vs/workbench/contrib/url/browser/trustedDomains';
+import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
 
 function linkAllowedByRules(link: string, rules: string[]) {
 	assert.ok(isURLDomainTrusted(URI.parse(link), rules), `Link\n${link}\n should be allowed by rules\n${JSON.stringify(rules)}`);
@@ -17,6 +18,7 @@ function linkNotAllowedByRules(link: string, rules: string[]) {
 }
 
 suite('GitHub remote extraction', () => {
+	ensureNoDisposablesAreLeakedInTestSuite();
 	test('All known formats', () => {
 		assert.deepStrictEqual(
 			extractGitHubRemotesFromGitConfig(
@@ -39,6 +41,7 @@ suite('GitHub remote extraction', () => {
 });
 
 suite('Link protection domain matching', () => {
+	ensureNoDisposablesAreLeakedInTestSuite();
 	test('simple', () => {
 		linkNotAllowedByRules('https://x.org', []);