Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insert range of ts entries with replacement spans #202287

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix insert range of ts entries with replacement spans #202287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/typescript-language-features/src/languageFeatures/completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ class MyCompletionItem extends vscode.CompletionItem {

// If TS returns an explicit replacement range, we should use it for both types of completion
return {
inserting: replaceRange,
inserting: new vscode.Range(replaceRange.start, this.position),
replacing: replaceRange,
};
}
Expand Down