Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API discussion points #203723

Merged
merged 1 commit into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vscode-dts/vscode.proposed.debugVisualization.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ declare module 'vscode' {
* the data provider, it will replace the variable in its tree.
* Otherwise, the items will be shown as children of the variable.
*/
// @API don't return TreeDataProvider but a reference to it, like its ids
visualization?: Command | TreeDataProvider<unknown>;

/**
Expand Down
3 changes: 3 additions & 0 deletions src/vscode-dts/vscode.proposed.quickPickSortByLabel.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ declare module 'vscode' {
/**
* An optional flag to sort the final results by index of first query match in label. Defaults to true.
*/
// @API is a bug that we need this API at all. why do we change the sort order
// when extensions give us a (sorted) array of items?
// @API sortByLabel isn't a great name
sortByLabel: boolean;
}
}
6 changes: 6 additions & 0 deletions src/vscode-dts/vscode.proposed.testCoverage.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ declare module 'vscode' {
* @param token A cancellation token.
* @return Coverage metadata for all files involved in the test.
*/
// @API - pass something into the provide method:
// (1) have TestController#coverageProvider: TestCoverageProvider
// (2) pass TestRun into this method
provideFileCoverage(token: CancellationToken): ProviderResult<T[]>;

/**
Expand Down Expand Up @@ -118,6 +121,9 @@ declare module 'vscode' {
);
}

// @API are StatementCoverage and BranchCoverage etc really needed
// or is a generic type with a kind-property enough

/**
* Contains coverage information for a single statement or line.
*/
Expand Down