Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inoperative try/catch #203904

Merged
merged 1 commit into from Feb 7, 2024
Merged

Conversation

CGNonofr
Copy link
Contributor

There is a try/catch preventing errors if invoked from a nested browsing context but at least in lastest chrome, the method returns a rejected promise in that case and the try/catch does nothing leading to an uncaught error

@ulugbekna
Copy link
Contributor

nice catch, thank you! ❤️

@VSCodeTriageBot VSCodeTriageBot added this to the February 2024 milestone Feb 7, 2024
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're gonna await it, I would rather see the .then removed, I find it confusing to mix and match

@ulugbekna ulugbekna merged commit 50bab6a into microsoft:main Feb 7, 2024
6 checks passed
@ulugbekna
Copy link
Contributor

I agree with the comment above, but let's address it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants