Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak/exception and links becoming bricked within the terminal #203915

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Fix leak/exception and links becoming bricked within the terminal #203915

merged 6 commits into from
Jan 31, 2024

Commits on Jan 31, 2024

  1. Avoid leaking link providers if link manager is already disposed 

    Fixes #203437
    @Tyriar
    Tyriar committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    fe8e444 View commit details
    Browse the repository at this point in the history

  2. Bind external link providers to link manager lifecycle 

    Fixes #203437
    @Tyriar
    Tyriar committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    29cd81a View commit details
    Browse the repository at this point in the history

  3. Use mutable disposable for link provider

    @Tyriar
    Tyriar committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b4eea3c View commit details
    Browse the repository at this point in the history

  4. Remove service brand from link resolver 

    It's not a service
    @Tyriar
    Tyriar committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4dc4b87 View commit details
    Browse the repository at this point in the history

  5. Fix maxLineContext expression 

    Looks like an accidental / instead of ,
    @Tyriar
    Tyriar committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4addb24 View commit details
    Browse the repository at this point in the history

  6. Dispose all link adapters when the link manager is disposed 

    Fixes #184046
    @Tyriar
    Tyriar committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    cb31b8d View commit details
    Browse the repository at this point in the history