Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to electron 28 #203956

Merged
merged 7 commits into from
Feb 26, 2024
Merged

chore: update to electron 28 #203956

merged 7 commits into from
Feb 26, 2024

Conversation

deepak1556
Copy link
Contributor

Fixes #201935
Fixes #203845

@deepak1556 deepak1556 added this to the February 2024 milestone Feb 1, 2024
@deepak1556 deepak1556 self-assigned this Feb 1, 2024
.yarnrc Outdated Show resolved Hide resolved
18.18.2 has npm version that has removed the node-gyp script
which will cause native modules fail to build that rely on
something like `install: node-gyp rebuild`

Refs npm/cli@c93edb5
@deepak1556 deepak1556 marked this pull request as ready for review February 26, 2024 09:50
@deepak1556 deepak1556 enabled auto-merge (squash) February 26, 2024 09:50
bpasero
bpasero previously approved these changes Feb 26, 2024
@deepak1556 deepak1556 merged commit 974c6b3 into main Feb 26, 2024
6 checks passed
@deepak1556 deepak1556 deleted the electron-28.x.y branch February 26, 2024 11:11
@JustinGrote
Copy link
Contributor

Has anyone actually tested if you can write a vscode extension in ES6 natively and have it load in vscode? Just curious, since that's one of the major standouts of this release.

@Malix-off
Copy link
Contributor

Malix-off commented Feb 27, 2024

Indeed.
If it works, you could add "fixes #130367" in the description

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't select a word with double click in exploration build Update to Electron 28
5 participants