Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window - mitigate macOS fullscreen issue with custom title #203986

Merged
merged 1 commit into from
Feb 1, 2024
Merged

window - mitigate macOS fullscreen issue with custom title #203986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/vs/platform/windows/electron-main/windowImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,14 @@ export abstract class BaseWindow extends Disposable implements IBaseWindow {
this.transientIsNativeFullScreen = undefined;
this.joinNativeFullScreenTransition = undefined;

if (!transitioned && fullscreen && fromRestore) {
// There is one interesting gotcha on macOS: when you are opening a new
// window from a fullscreen window, that new window will immediately
// open fullscreen and emit the `enter-full-screen` event even before we
// reach this method. In that case, we actually will timeout after 10s
// for detecting the transition and as such it is important that we only
// signal to leave fullscreen if the window reports as not being in fullscreen.

if (!transitioned && fullscreen && fromRestore && this.win && !this.win.isFullScreen()) {

// We have seen requests for fullscreen failing eventually after some
// time, for example when an OS update was performed and windows restore.
Expand Down