Try use shell integration in debug terminals #205034
Conversation
There was a problem hiding this comment.
Thanks. Waiting on debug team: #204694 (comment) before approving.
There was a problem hiding this comment.
Based on #204694 (comment) it looks like this will also require changes to RunInterminalRequestArguments.
|
What was the issue with always enabling this? |
|
If we can always enable shell integration by default (thereby enabling it for debug terminals) that'd be great. |
|
Let's merge this early next iteration and see if there's any negative feedback for insiders |
| * Attempt to force shell integration to be enabled by bypassing the {@link isFeatureTerminal} | ||
| * equals false requirement. | ||
| */ | ||
| forceShellIntegration?: boolean; |
There was a problem hiding this comment.
Looking at this PR, I'm not clear if it is always enabled for debug terminals by default. Can you clarify? Looks to me like we're not forcing shell integration as default.
There was a problem hiding this comment.
Not always, but it will attempt to just like any other terminal. Previously "feature terminals" would all be excluded.
There was a problem hiding this comment.
Okay, who is using forceShellIntegration option? Note Python extension cannot access this property at the moment when debugging.
There was a problem hiding this comment.
@karrtikr it's internal only (see no vscode.d.ts change) and only used right now for debug terminals
Fixes #204694
Shell integration when debugging xterm.js' unit tests with
console: integratedTerminalset.