Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git - add "Hard wrap all lines" code action is there are multiple long lines #205349

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Git - add "Hard wrap all lines" code action is there are multiple long lines #205349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0c7841
Git - add "Hard wrap all lines" code action is there are multiple lon…
lszomoru Feb 16, 2024
2d2d237
💄 Moved code around
lszomoru Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 44 additions & 8 deletions extensions/git/src/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export class GitCommitInputBoxCodeActionsProvider implements CodeActionProvider
provideCodeActions(document: TextDocument, range: Range | Selection): CodeAction[] {
const codeActions: CodeAction[] = [];
const diagnostics = this.diagnosticsManager.getDiagnostics(document.uri);
const wrapAllLinesCodeAction = this.getWrapAllLinesCodeAction(document, diagnostics);

for (const diagnostic of diagnostics) {
if (!diagnostic.range.contains(range)) {
Expand All @@ -96,17 +97,23 @@ export class GitCommitInputBoxCodeActionsProvider implements CodeActionProvider
const codeAction = new CodeAction(l10n.t('Remove empty characters'), CodeActionKind.QuickFix);
codeAction.diagnostics = [diagnostic];
codeAction.edit = workspaceEdit;

codeActions.push(codeAction);

break;
}
case DiagnosticCodes.line_length: {
const workspaceEdit = this.getWrapLineWorkspaceEdit(document, diagnostic.range);

const codeAction = new CodeAction(l10n.t('Hard wrap line'), CodeActionKind.QuickFix);
codeAction.diagnostics = [diagnostic];
codeAction.edit = workspaceEdit;

codeActions.push(codeAction);

if (wrapAllLinesCodeAction) {
wrapAllLinesCodeAction.diagnostics = [diagnostic];
codeActions.push(wrapAllLinesCodeAction);
}

break;
}
}
Expand All @@ -116,13 +123,45 @@ export class GitCommitInputBoxCodeActionsProvider implements CodeActionProvider
}

private getWrapLineWorkspaceEdit(document: TextDocument, range: Range): WorkspaceEdit {
const lineSegments = this.wrapTextDocumentLine(document, range.start.line);

const workspaceEdit = new WorkspaceEdit();
workspaceEdit.replace(document.uri, range, lineSegments.join('\n'));

return workspaceEdit;
}

private getWrapAllLinesCodeAction(document: TextDocument, diagnostics: readonly Diagnostic[]): CodeAction | undefined {
const lineLengthDiagnostics = diagnostics.filter(d => d.code === DiagnosticCodes.line_length);
if (lineLengthDiagnostics.length < 2) {
return undefined;
}

const wrapAllLinesCodeAction = new CodeAction(l10n.t('Hard wrap all lines'), CodeActionKind.QuickFix);
wrapAllLinesCodeAction.edit = this.getWrapAllLinesWorkspaceEdit(document, lineLengthDiagnostics);

return wrapAllLinesCodeAction;
}

private getWrapAllLinesWorkspaceEdit(document: TextDocument, diagnostics: Diagnostic[]): WorkspaceEdit {
const workspaceEdit = new WorkspaceEdit();

for (const diagnostic of diagnostics) {
const lineSegments = this.wrapTextDocumentLine(document, diagnostic.range.start.line);
workspaceEdit.replace(document.uri, diagnostic.range, lineSegments.join('\n'));
}

return workspaceEdit;
}

private wrapTextDocumentLine(document: TextDocument, line: number): string[] {
const config = workspace.getConfiguration('git');
const inputValidationLength = config.get<number>('inputValidationLength', 50);
const inputValidationSubjectLength = config.get<number | undefined>('inputValidationSubjectLength', undefined);
const lineLengthThreshold = range.start.line === 0 ? inputValidationSubjectLength ?? inputValidationLength : inputValidationLength;
const lineLengthThreshold = line === 0 ? inputValidationSubjectLength ?? inputValidationLength : inputValidationLength;

const lineSegments: string[] = [];
const lineText = document.lineAt(range.start.line).text;
const lineText = document.lineAt(line).text;

let position = 0;
while (lineText.length - position > lineLengthThreshold) {
Expand All @@ -147,10 +186,7 @@ export class GitCommitInputBoxCodeActionsProvider implements CodeActionProvider
lineSegments.push(lineText.substring(position));
}

const workspaceEdit = new WorkspaceEdit();
workspaceEdit.replace(document.uri, range, lineSegments.join('\n'));

return workspaceEdit;
return lineSegments;
}

dispose() {
Expand Down